Skip to content

Comments

Remove auto-scroll on series event pagination#308

Merged
geoff-maddock merged 2 commits intomainfrom
copilot/fix-pagination-scroll-issue
Nov 25, 2025
Merged

Remove auto-scroll on series event pagination#308
geoff-maddock merged 2 commits intomainfrom
copilot/fix-pagination-scroll-issue

Conversation

Copy link
Contributor

Copilot AI commented Nov 22, 2025 •
edited
Loading

Pagination on series detail pages was scrolling the viewport to top on page change, forcing users to scroll back down to continue viewing events.

Changes

  • SeriesEvents.tsx: Removed window.scrollTo() call from handlePageChange handler
  • SeriesEvents.test.tsx: Added test suite covering pagination behavior including verification that page changes don't trigger scrolling
// Before
const handlePageChange = (newPage: number) => {
    setPage(newPage);
    window.scrollTo({ top: 0, behavior: 'smooth' });
};

// After
const handlePageChange = (newPage: number) => {
    setPage(newPage);
};

Users can now navigate through paginated events while maintaining scroll position.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • test.api
    • Triggering command: /usr/local/bin/node /usr/local/bin/node --conditions node --conditions development /home/REDACTED/work/arcane-city-frontend/arcane-city-frontend/node_modules/tinypool/dist/entry/process.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Series Detail page - fix pagination auto scrolling</issue_title>
<issue_description>When a user is on a series detail page such as
https://beta.arcane.city/series/lazercrunk

There is a paginated list of events that are related to the series at the bottom of the page.
When you change pages, the viewport scrolls back to the top (which may be because it's technically a new page).

I would like to prevent this scrolling, and keep the scroll position in the same place so you can see the next page of events without having to scroll back down.</issue_description>

Comments on the Issue (you are @copilot in this section)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Nov 22, 2025
@vercel
Copy link

vercel bot commented Nov 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
arcane-city-frontend Ready Ready Preview Comment Nov 22, 2025 6:55am

@geoff-maddock
Fix pagination auto scrolling on series detail page
bd65cd7 
Co-authored-by: geoff-maddock <55493+geoff-maddock@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix pagination auto scrolling on series detail page Remove auto-scroll on series event pagination Nov 22, 2025
Copilot AI requested a review from geoff-maddock November 22, 2025 06:59
@geoff-maddock geoff-maddock marked this pull request as ready for review November 25, 2025 04:22
@geoff-maddock geoff-maddock merged commit 44cf5c7 into main Nov 25, 2025
16 checks passed
@github-actions
Copy link

github-actions bot commented Nov 25, 2025

📦 Build Size Report

@github-actions
Copy link

github-actions bot commented Nov 25, 2025

✅ PR Checks Complete

Tests Status: success
Node.js Version: 20.x
Commit: bd65cd7

All tests in src/__tests__ have been executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geoff-maddock geoff-maddock Awaiting requested review from geoff-maddock

Assignees

@geoff-maddock geoff-maddock

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Series Detail page - fix pagination auto scrolling

2 participants

@geoff-maddock